Limit use of Posix threads to Unix #4140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Posix threads are available only on Unix (and unix like) platforms. Wrap the dependency accordingly so builds don't fail on other platforms. Signed-off-by: HS <[email protected]>
Collaborator
Author
|
@parrt Can you assist with getting this merged to master. Thanks! |
Member
|
hyperbusy but soon. we have similar PR btw. |
Contributor
|
|
Collaborator
Author
|
When antlr is exported as a dependency, Threads ends up in the antlr4.cmake file which doesn't resolve to nothing, at least on Windows. This is the currently the case for Surelog where the builds are failing for projects dependent on Surelog library, only on Windows where cmake fails to resolve it. |
Collaborator
Author
|
@jmairboeck @parrt Any update on this PR? |
jimidle
pushed a commit
to jimidle/antlr4
that referenced
this pull request
Mar 28, 2023
Posix threads are available only on Unix (and unix like) platforms. Wrap the dependency accordingly so builds don't fail on other platforms. Signed-off-by: HS <[email protected]> Signed-off-by: Jim.Idle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Posix threads are available only on Unix (and unix like) platforms. Wrap the dependency accordingly so builds don't fail on other platforms.
Signed-off-by: HS [email protected]